Skip to content

Translation Guidelines for Developer Docs #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 6, 2020
Merged

Translation Guidelines for Developer Docs #1598

merged 7 commits into from
Sep 6, 2020

Conversation

oruburos
Copy link
Collaborator

@oruburos oruburos commented Sep 3, 2020

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named

@oruburos
Copy link
Collaborator Author

oruburos commented Sep 3, 2020

@andrewn can you have a look at this, please?

andrewn
andrewn suggested changes Sep 4, 2020
View reviewed changes
Copy link
Member

@andrewn andrewn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking very good. The main issues:

  • proper markdown heading levels should be used for all section titles
  • some small language tweaks

@oruburos
Copy link
Collaborator Author

oruburos commented Sep 4, 2020

@andrewn can you have a look at this, please? I updated the branch and addressed the comments.

@catarak
Copy link
Member

catarak commented Sep 4, 2020

Yay! Thanks for working on this ✨ I'm so excited that this opens up future translations for the web editor!

andrewn
andrewn approved these changes Sep 6, 2020
View reviewed changes
Copy link
Member

@andrewn andrewn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! This is a great resource for future translators!

@andrewn andrewn merged commit 260a92d into processing:develop Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewn andrewn andrewn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oruburos @catarak @andrewn